fix: failed to parse bundle with IIFE#685
Conversation
|
@evenstensberg We need to add test cases |
valscion
left a comment
valscion
left a comment
There was a problem hiding this comment.
Hmm yeah this might work but it looks like we would not be parsing any modules when this IIFE bundle is used? Is that expected?
Anyway, this looks good! Could you still add a changelog entry?
|
@valscion In this case there are no modules, anyway in our TODOs to add all test cases for ES modules with and without IIFE, it is just an edge case |
|
Yeah that's true. I'll add a changelog entry myself when I have the time or then @hai-x can add one — I'll merge once the changelog is there and release when I have a good slot :) |
|
@valscion I'm so sorry, I missed the message and forgot to reply. Thank you for your help. ❤️ |
|
Sure, not a problem @hai-x! |
|
Released in v5.1.1. Thanks for the contribution! |
4 participants
Summary
What kind of change does this PR introduce?
Fixes #684, #409.
Did you add tests for your changes?
It seems we currently don’t support parsing top-level chunk modules and i’m also not sure whether parsing is the right approach for get rendered chunk modules.
e.g.
So i add one simple IIFE case here without chunk modules.
Here is test result before fixing:
Does this PR introduce a breaking change?
No
If relevant, what needs to be documented once your changes are merged or what have you already documented?
No